Skip to content

Issue #101: run bestPractices recipe with build #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2025
Merged

Issue #101: run bestPractices recipe with build #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 0 additions & 58 deletions .github/workflows/comment-pr.yml
View file
Open in desktop

This file was deleted.

66 changes: 0 additions & 66 deletions .github/workflows/receive-pr.yml
View file
Open in desktop

This file was deleted.

9 changes: 6 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
<maven.compiler.plugin>3.11.0</maven.compiler.plugin>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<rewrite.maven.plugin>6.16.0</rewrite.maven.plugin>
<recipe.bom.version>3.13.0</recipe.bom.version>
<rewrite.maven.plugin>6.17.0</rewrite.maven.plugin>
<recipe.bom.version>3.14.0</recipe.bom.version>
<junit.version>5.13.4</junit.version>
<assertj.version>3.27.4</assertj.version>

Expand Down Expand Up @@ -173,6 +173,9 @@
<version>${rewrite.maven.plugin}</version>
<configuration>
<activeRecipes>
<recipe>org.checkstyle.recipes.OpenRewriteRecipeBestPractices</recipe>
<recipe>org.checkstyle.recipes.JavaRecipeBestPractices</recipe>
<recipe>org.checkstyle.recipes.RecipeTestingBestPracticesSubset</recipe>
<recipe>CheckstyleAutoFixConfigured</recipe>
</activeRecipes>
<exclusions>
Expand All @@ -188,7 +191,7 @@
<dependency>
<groupId>org.openrewrite.recipe</groupId>
<artifactId>rewrite-rewrite</artifactId>
<version>RELEASE</version>
<version>0.12.1</version>
</dependency>
</dependencies>
<executions>
Expand Down
5 changes: 3 additions & 2 deletions rewrite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,14 @@ preconditions:
recipeList:
- org.openrewrite.java.recipes.BlankLinesAroundFieldsWithAnnotations
- org.openrewrite.java.recipes.CorrectlySpacedDescriptions
# - org.openrewrite.java.recipes.ExecutionContextParameterName
- org.openrewrite.java.recipes.ExecutionContextParameterName:
parameterName: executionContext
- org.openrewrite.java.recipes.IsLiteralNullRecipe
- org.openrewrite.java.recipes.MissingOptionExample
- org.openrewrite.java.recipes.NoMutableStaticFieldsInRecipes
Copy link
Contributor

@timtebeek timtebeek Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- org.openrewrite.java.recipes.NoMutableStaticFieldsInRecipes
- org.openrewrite.java.recipes.ExecutionContextParameterName:
parameterName: executionContext
- org.openrewrite.java.recipes.NoMutableStaticFieldsInRecipes

Copy link
Contributor

@timtebeek timtebeek Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one was commented out above, but was recently extended to take a configurable variable name in response to the feedback received here:
openrewrite/rewrite-rewrite@c52c549

- org.openrewrite.java.recipes.RecipeEqualsAndHashCodeCallSuper
- org.openrewrite.java.recipes.UseTreeRandomId
- org.openrewrite.java.recipes.migrate.RemoveTraitsUsageRecipes
- org.openrewrite.java.InlineMethodCalls
- org.openrewrite.staticanalysis.NeedBraces
Copy link
Contributor

@timtebeek timtebeek Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- org.openrewrite.staticanalysis.NeedBraces
- org.openrewrite.java.InlineMethodCalls
- org.openrewrite.staticanalysis.NeedBraces

Copy link
Contributor

@timtebeek timtebeek Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This recipe replaces the older RemoveTraitsUsageRecipes, as indicated hre:

- org.openrewrite.staticanalysis.RemoveSystemOutPrintln
- org.openrewrite.java.RemoveAnnotation:
Expand Down
3 changes: 2 additions & 1 deletion src/main/java/org/checkstyle/autofix/recipe/RedundantImport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ private final class RemoveRedundantImportsVisitor extends JavaIsoVisitor<Executi
private Path sourcePath;

@Override
public J.CompilationUnit visitCompilationUnit(J.CompilationUnit cu, ExecutionContext ctx) {
public J.CompilationUnit visitCompilationUnit(J.CompilationUnit cu,
ExecutionContext executionContext) {
Copy link
Contributor

@timtebeek timtebeek Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see the addition of parameterName to ExecutionContextParameterName has helped consistency here. 🚀


this.sourcePath = cu.getSourcePath().toAbsolutePath();

Expand Down
Loading