Skip to content

Issue #124: Implement recipe for NewlineAtEndOfFile#125

Merged
rdiachenko merged 1 commit intocheckstyle:mainfrom
Anmol202005:eol
Jan 25, 2026
Merged

Issue #124: Implement recipe for NewlineAtEndOfFile#125
rdiachenko merged 1 commit intocheckstyle:mainfrom
Anmol202005:eol

Conversation

@Anmol202005
Copy link
Collaborator

@Anmol202005 Anmol202005 commented Oct 30, 2025

Fixes: #124

Implemented recipe for NewlineAtEndOfFile: https://checkstyle.sourceforge.io/checks/misc/newlineatendoffile.html

@Anmol202005 Anmol202005 force-pushed the eol branch 15 times, most recently from 8b311bc to e5cc5a3 Compare October 30, 2025 19:29
@Anmol202005
Copy link
Collaborator Author

Anmol202005 commented Oct 30, 2025

Finally got CI GREEN.

@rdiachenko pls review :)

@Anmol202005
Copy link
Collaborator Author

Anmol202005 commented Nov 9, 2025

@romani @rdiachenko ping.

romani
romani requested changes Nov 9, 2025
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for delay ...

items:

src/main/java/org/checkstyle/autofix/recipe/NewlineAtEndOfFile.java Outdated
final Space eof = sourceFile.getEof();
final String lastWhitespace = eof.getLastWhitespace();

if (!lineEnding.equals(lastWhitespace)) {
Copy link
Member

@romani romani Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do not trust checkstyle violation ? or it is save check in case of second execution.

Copy link
Collaborator Author

@Anmol202005 Anmol202005 Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a check for second execution.

romani
romani requested changes Nov 14, 2025
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last:

rdiachenko
rdiachenko reviewed Nov 16, 2025
View reviewed changes
@Anmol202005 Anmol202005 force-pushed the eol branch 2 times, most recently from 6d359ff to a4eac5f Compare November 17, 2025 00:25
@romani romani mentioned this pull request Nov 19, 2025
Closed
romani
romani approved these changes Nov 19, 2025
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need explicitly add this recipe to checkstyle main repo config to be executed by CI ?

thansk a lot for your work.

@Anmol202005
Copy link
Collaborator Author

Anmol202005 commented Nov 19, 2025 •
edited by romani
Loading

Do we need explicitly add this recipe to checkstyle main repo config to be executed by CI ?

No
https://github.com/checkstyle/checkstyle/blob/50aa6850b3b6e1cf3fd7ac0238ba269b01753471/rewrite.yml#L6-L11

@romani
Copy link
Member

romani commented Nov 20, 2025

@rdiachenko , please finish review

rdiachenko
rdiachenko approved these changes Nov 22, 2025
View reviewed changes
Copy link
Member

@rdiachenko rdiachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rdiachenko
Copy link
Member

rdiachenko commented Nov 22, 2025

@Anmol202005 please update README with proper links to a new recipe, and ok to merge after that

@romani
Copy link
Member

romani commented Nov 22, 2025

After rebase , there might be some pitest mutations, just add them to suppression. No suppression rule will be enforced after this PR

@romani
Copy link
Member

romani commented Nov 23, 2025

@Anmol202005 , if you send PR for #127 (comment), system will print patch for suppression and it will be easy to update suppression.

@Anmol202005 Anmol202005 force-pushed the eol branch 3 times, most recently from 66203f7 to 5f40320 Compare January 20, 2026 18:47
@Anmol202005
Copy link
Collaborator Author

Anmol202005 commented Jan 20, 2026

@romani cant we use https://pitest.org/quickstart/maven/#excludedClasses, to suppress already made recipes instead of using .xml file suppressions. IG this will help maintain mutation score and make the CI green.

@Anmol202005
Copy link
Collaborator Author

Anmol202005 commented Jan 23, 2026

@romani ping

@romani cant we use https://pitest.org/quickstart/maven/#excludedClasses, to suppress already made recipes instead of using .xml file suppressions. IG this will help maintain mutation score and make the CI green.

@romani
Copy link
Member

romani commented Jan 25, 2026 •
edited
Loading

@Anmol202005 , we should fully rely on
https://github.com/checkstyle/checkstyle-openrewrite-recipes/blob/main/config/pitest-suppressions.xml

job supposed to print diff strange that I do not see it.

Execution of comparison of suppressed mutations survivals and current survivals:
groovy .ci/pitest-survival-check.groovy
No new surviving mutation(s) found.

ok it is because you added all to suppression.

@romani
Copy link
Member

romani commented Jan 25, 2026

please reduce threshold to 84.
to let CI pass, after this PR, we will not allow pitest survivals

@Anmol202005
Copy link
Collaborator Author

Anmol202005 commented Jan 25, 2026

@romani done.

@rdiachenko rdiachenko merged commit cf419b3 into checkstyle:main Jan 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

@rdiachenko rdiachenko rdiachenko approved these changes

Assignees

@rdiachenko rdiachenko

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement recipe for NewlineAtEndOfFile

3 participants

@Anmol202005 @romani @rdiachenko