Skip to content

Issue #43: updated CheckstyleViolation to change line and column to primitive #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025
Merged

Issue #43: updated CheckstyleViolation to change line and column to primitive #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/java/org/checkstyle/autofix/parser/CheckstyleReportParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,8 @@ private static String parseFileTag(StartElement startElement) {
}

private static CheckstyleViolation parseErrorTag(StartElement startElement, String filename) {
Integer line = null;
Integer column = null;
int line = -1;
int column = -1;
String source = null;
String message = null;
String severity = null;
Expand All @@ -124,7 +124,7 @@ private static CheckstyleViolation parseErrorTag(StartElement startElement, Stri
final String attrName = attribute.getName().getLocalPart();
switch (attrName) {
case LINE_ATTR:
line = Integer.valueOf(attribute.getValue());
line = Integer.parseInt(attribute.getValue());
break;
case COLUMN_ATTR:
column = Integer.parseInt(attribute.getValue());
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/org/checkstyle/autofix/parser/CheckstyleViolation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@

public final class CheckstyleViolation {

private final Integer line;
private final int line;

private final Integer column;
private final int column;

private final String severity;

Expand All @@ -31,7 +31,7 @@ public final class CheckstyleViolation {

private final String fileName;

public CheckstyleViolation(Integer line, Integer column,
public CheckstyleViolation(int line, int column,
String severity, String source, String message, String fileName) {
this.line = line;
this.column = column;
Expand Down
Loading