Issue #41: Added InptConfigRemover recipe for preprocessing #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdiachenko
requested changes
Jul 20, 2025
Member
rdiachenko
left a comment
rdiachenko
left a comment
There was a problem hiding this comment.
I don't think we should remove config header. The idea was to remove // violation comments from those lines where violation was fixed. When you open InputXXX and OutputXXX side by side, the diff should only contain fixed violations and removed // violation comment, meaning it was fixed. If we remove config header, it will be harder to do such comparisons
Collaborator
Author
|
Done. |
rdiachenko
reviewed
Jul 21, 2025
src/test/java/org/checkstyle/autofix/RemoveViolationComments.java
Outdated
Show resolved
Hide resolved
rdiachenko
approved these changes
Jul 22, 2025
Member
rdiachenko
left a comment
rdiachenko
left a comment
There was a problem hiding this comment.
lgtm
if we need to support more complex comments or parameterise the recipe with a different comment, we'll do it when we have a real case for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #41
follow up of: #57
Added recipe
InputConfiigRemoverto remove inline configuration comments.