Implemented Checkstyle to project #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anmol202005
force-pushed
the
implCheckstyle2
branch
from
0d03e9c to
d33c99a
Compare
rdiachenko
approved these changes
Jun 8, 2025
Comment on lines
+8
to
+11
| <suppress checks="HeaderCheck" files=".*"/> | ||
| <suppress checks="RegexpHeader" files=".*"/> | ||
| <suppress checks="header" files=".*\.java"/> | ||
| <suppress checks="multiFileRegexpHeader" files=".*"/> |
Member
There was a problem hiding this comment.
Ok for now as we are in exploration mode. Please investigate whether we need to include a license header given the license for this project and create issue to update all files and remove this supressions. When project is stabilised, that will be a good time fix this.
Closed
Member
|
@Anmol202005 , @rdiachenko , it will be good to eat food we produce, so after compilation/assemble CI runs auto fix on its own sources, and falilng if there is any diff. |
Member
yep, that's the plan, thanks! @Anmol202005 please create issue for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5
Added checkstyle to project to ensure code readability and consistent code style.