Issue #68: Updated header recipe to prepend the expected header #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anmol202005
force-pushed
the
headerUpdate
branch
2 times, most recently
from
ba3b0a4 to
2b58c87
Compare
romani
reviewed
Jul 28, 2025
...test/resources/org/checkstyle/autofix/recipe/header/headercomments/OutputHeaderComments.java
Show resolved
Hide resolved
timurt
approved these changes
Jul 30, 2025
| // This file is part of the Checkstyle OpenRewrite test suite. | ||
| /////////////////////////////////////////////////////////////////////////////////////////////// | ||
|
|
||
| /////////////////////////////////////////////////////////////////////////////////////////////// |
Collaborator
There was a problem hiding this comment.
I am okay with the approach, but just always prepending sounds like we might miss some opportunities
if the input file has no header -> prepend
If the input file has a header and the number of lines mismatches config header -> prepend
if the input file has a header and the number of lines is the same -> override
Something that can be considered later
Member
There was a problem hiding this comment.
@Anmol202005 please create issue so we track it and refer to it. We don't have much data yet to decide what's the best way to handle this. Let's keep it as issue for later
Anmol202005
force-pushed
the
headerUpdate
branch
from
2b58c87 to
275ff68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #68
Changed recipe logic to prepend header to the existing comments.