Deployed to Maven Central #9
Conversation
pom.xml
Outdated
| <version>9</version> | ||
| </parent> | ||
|
|
||
| <groupId>org.checkstyle.autofix</groupId> |
There was a problem hiding this comment.
I think we can org.checkstyle only for group.
it is ok to have plugins/tools to be just under "checkstyle"
There was a problem hiding this comment.
In the patch-filter project I see latest master has <groupId>com.puppycrawl.tools</groupId>, shall we go with the same groupId? Better to agree on this now while we are still at the start of the project
There was a problem hiding this comment.
https://repo1.maven.org/maven2/org/checkstyle
Is not existing, so it means it will be a special process to claim ownership of such domain.
Lets use group common for all , as Ruslan suggested
https://repo1.maven.org/maven2/com/puppycrawl/tools/
|
I think we should not be obsessed to deploy to maven central jar too early. We can always put jar to maven local repository and use special profile to activate openrewrite to fix code. scenario: it will help us take maturity withtout bothering much existing dev process of checkstyle. We will share knowledge on this, so users will likely to run it manually and give feedback and not be blocked if any problems happens with auto-fixes. |
|
@Anmol202005 what's the status of this PR? Let's finish it |
|
@Anmol202005 please resolve conflicts |
done. |
Anmol202005
force-pushed
the
deploy
branch
2 times, most recently
from
732d01d to
69258f2
Compare
rdiachenko
left a comment
rdiachenko
left a comment
There was a problem hiding this comment.
The change looks good to me. @romani please take a look when you have time as you have a better context regarding deployment to maven central
|
rebased on main |
romani
left a comment
romani
left a comment
There was a problem hiding this comment.
lets go.
I will do release only after we make sure it works on SNAPSHOT version
3 participants
Fixes: #6
Configured pom.xml for maven central deployment.