-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Issue #3730: Add type annotation tokens to AnnotationLocation check #17970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Hariom-kr
wants to merge
1
commit into
checkstyle:master
Choose a base branch
from
Hariom-kr:annotationlocation-xdoc-ex
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
...urces/com/puppycrawl/tools/checkstyle/checks/annotation/annotationlocation/Example10.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| /*xml | ||
| <module name="Checker"> | ||
| <module name="TreeWalker"> | ||
| <module name="AnnotationLocation"> | ||
| <property name="tokens" value="DOT"/> | ||
| </module> | ||
| </module> | ||
| </module> | ||
| */ | ||
|
|
||
| package com.puppycrawl.tools.checkstyle.checks.annotation.annotationlocation; | ||
|
|
||
| import java.lang.annotation.ElementType; | ||
| import java.lang.annotation.Target; | ||
|
|
||
| @Target(ElementType.TYPE_USE) | ||
| @interface DotAnnotation1 {} | ||
|
|
||
| @Target(ElementType.TYPE_USE) | ||
| @interface DotAnnotation2 {} | ||
|
|
||
| // xdoc section -- start | ||
| class Example10 { | ||
| void method() { | ||
| java.lang.@DotAnnotation1 String s; // ok | ||
| java.lang.@DotAnnotation1 @DotAnnotation2 String s2; | ||
| // violation above, 'Annotation 'DotAnnotation2' should be alone on line.' | ||
| } | ||
| } | ||
| // xdoc section -- end |
31 changes: 31 additions & 0 deletions
31
...ources/com/puppycrawl/tools/checkstyle/checks/annotation/annotationlocation/Example5.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| /*xml | ||
| <module name="Checker"> | ||
| <module name="TreeWalker"> | ||
| <module name="AnnotationLocation"> | ||
| <property name="tokens" value="TYPE_ARGUMENT"/> | ||
| </module> | ||
| </module> | ||
| </module> | ||
| */ | ||
|
|
||
| package com.puppycrawl.tools.checkstyle.checks.annotation.annotationlocation; | ||
|
|
||
| import java.lang.annotation.ElementType; | ||
| import java.lang.annotation.Target; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| @Target(ElementType.TYPE_USE) | ||
| @interface TypeArgAnnotation1 {} | ||
|
|
||
| @Target(ElementType.TYPE_USE) | ||
| @interface TypeArgAnnotation2 {} | ||
|
|
||
| // xdoc section -- start | ||
| class Example5 { | ||
| List<@TypeArgAnnotation1 String> names; // ok | ||
| List<@TypeArgAnnotation1 @TypeArgAnnotation2 String> data; | ||
| // violation above, 'Annotation 'TypeArgAnnotation2' should be alone on line.' | ||
| Map<@TypeArgAnnotation1 String, @TypeArgAnnotation1 Integer> map; // ok | ||
| } | ||
| // xdoc section -- end | ||
30 changes: 30 additions & 0 deletions
30
...ources/com/puppycrawl/tools/checkstyle/checks/annotation/annotationlocation/Example6.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| /*xml | ||
| <module name="Checker"> | ||
| <module name="TreeWalker"> | ||
| <module name="AnnotationLocation"> | ||
| <property name="tokens" value="TYPECAST"/> | ||
| </module> | ||
| </module> | ||
| </module> | ||
| */ | ||
|
|
||
| package com.puppycrawl.tools.checkstyle.checks.annotation.annotationlocation; | ||
|
|
||
| import java.lang.annotation.ElementType; | ||
| import java.lang.annotation.Target; | ||
|
|
||
| @Target(ElementType.TYPE_USE) | ||
| @interface TypeCastAnnotation1 {} | ||
|
|
||
| @Target(ElementType.TYPE_USE) | ||
| @interface TypeCastAnnotation2 {} | ||
|
|
||
| // xdoc section -- start | ||
| class Example6 { | ||
| void method(Object obj) { | ||
| String s1 = (@TypeCastAnnotation1 String) obj; // ok | ||
| String s2 = (@TypeCastAnnotation1 @TypeCastAnnotation2 String) obj; | ||
| // violation above, 'Annotation 'TypeCastAnnotation2' should be alone on line.' | ||
| } | ||
| } | ||
| // xdoc section -- end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove all OK comments.
in all files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay