infra: re-enable IllegalInstantiation check

Author: Bananeweizen

config/checkstyle_checks.xml

@@ -202,6 +202,15 @@
             <property name="ignoreSetter" value="true"/>
             <property name="setterCanReturnItsClass" value="true"/>
         </module>
+        <module name="IllegalInstantiation">
+            <property name="classes"
+                      value="org.xml.sax.SAXException, org.xml.sax.SAXParseException,
+                         org.apache.commons.beanutils.ConversionException,
+                         org.antlr.v4.runtime.misc.ParseCancellationException,
+                         antlr.RecognitionException, antlr.TokenStreamException,
+                         antlr.TokenStreamRecognitionException, antlr.ANTLRException,
+                         java.lang.StringBuffer"/>
+        </module>
         <module name="IllegalThrows"/>
         <module name="IllegalTokenText">
             <property name="tokens" value="STRING_LITERAL"/>

net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/util/XMLUtil.java

@@ -45,7 +45,7 @@ private XMLUtil() {
 
   /**
    * Creates a pretty printed representation of the document as a byte array.
-   * 
+   *
    * @param document
    *          the document
    * @return the document as a byte array (UTF-8)
@@ -66,7 +66,7 @@ public static byte[] toByteArray(Document document) throws IOException {
 
   /**
    * Entity resolver which handles mapping public DTDs to internal DTD resource.
-   * 
+   *
    * @author Lars Ködderitzsch
    */
   public static class InternalDtdEntityResolver implements EntityResolver {
@@ -75,7 +75,7 @@ public static class InternalDtdEntityResolver implements EntityResolver {
 
     /**
      * Creates the entity resolver using a mapping of public DTD name to internal DTD resource.
-     * 
+     *
      * @param public2InternalDtdMap
      *          the public2internal DTD mapping
      */
@@ -95,6 +95,7 @@ public InputSource resolveEntity(String publicId, String systemId) throws SAXExc
 
         final InputStream dtdIS = getClass().getClassLoader().getResourceAsStream(dtdResourceName);
         if (dtdIS == null) {
+          // -@cs[IllegalInstantiation] SAXException is in the overridden method signature
           throw new SAXException("Unable to load internal dtd " + dtdResourceName); //$NON-NLS-1$
         }
         return new InputSource(dtdIS);