Skip to content

Commit 2fe1018

Browse files
committed
minor: disable TooBroadScope rule as it is not possible to suppress by javadoc annotation
1 parent 5cba6ae commit 2fe1018

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

checkstyle-sonar-plugin/config/intellij-idea-inspections.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1977,8 +1977,6 @@
19771977
<option value="deprecation" />
19781978
<option value="unchecked" />
19791979
<option value="rawtypes" />
1980-
<!-- Locale changes and caching, requires storage of value in advance in final -->
1981-
<option value="TooBroadScope" />
19821980
</list>
19831981
</option>
19841982
</inspection_tool>
@@ -2092,7 +2090,8 @@
20922090
<inspection_tool class="ToArrayCallWithZeroLengthArrayArgument" enabled="true" level="ERROR" enabled_by_default="true" />
20932091
<inspection_tool class="TodoComment" enabled="false" level="ERROR" enabled_by_default="false" />
20942092
<inspection_tool class="TooBroadCatch" enabled="false" level="ERROR" enabled_by_default="false" />
2095-
<inspection_tool class="TooBroadScope" enabled="true" level="ERROR" enabled_by_default="true">
2093+
<!-- I failed to suppress by javadoc annotation certain violation, some bug ... -->
2094+
<inspection_tool class="TooBroadScope" enabled="false" level="ERROR" enabled_by_default="true">
20962095
<option name="m_allowConstructorAsInitializer" value="false" />
20972096
<option name="m_onlyLookAtBlocks" value="false" />
20982097
</inspection_tool>

checkstyle-sonar-plugin/src/test/java/org/sonar/plugins/checkstyle/CheckstyleExecutorTest.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -111,11 +111,6 @@ private static JavaResourceLocator createJavaResourceLocator() {
111111
return new DefaultJavaResourceLocator(null, javaClasspath, null);
112112
}
113113

114-
/**
115-
* This is fake description just to keep noinspection.
116-
* @noinspection TooBroadScope
117-
* @throws Exception all could happen
118-
*/
119114
@Test
120115
public void generateXmlReportInEnglish() throws Exception {
121116
final Locale initialLocale = Locale.getDefault();

0 commit comments

Comments
 (0)