Issue #546: update checkstyle to 10.21.4 #547
Conversation
|
@muhlba91 , please finalize review |
|
@romani as you mentioned you review proposals of only from contributors passed qualifications by sending PRs, i was going through all repos of org and trying to fix as many as possible. once i have some merge PR will review my proposal?? |
|
@muhlba91 , let us know if you would like to do each big fix release separately. |
Ok, you most likely talking about GSoC qualificattion. |
|
@romani yeah sure i would love to do that, i will open it right now once i test it locally after changes and merge those before this PR. |
Gotcha, i have opened an issue can you approve it so i can fix it, checkstyle/checkstyle#16504. |
|
Please finish updates in plugins, they will count also to your points. |
Sure. |
|
@romani not sure about this one do this need jump to 10.21.4
|
|
my current maven version and tested on 3.9.9 below is logs
@romani suggest me with which changes i should proceed. |
|
i think first 5 will be the only change we should do and make changes to plugin accordingly |
|
Please update Line 806 in 7e1aa63 To 3.3.9 |
muhlba91
left a comment
muhlba91
left a comment
There was a problem hiding this comment.
lgtm!
please squash your commits into one following the commit format. 🙂
fix: update Checkstyle version in compatibility matrix to 10.21.4 fix: update required Maven version to 3.3.9 in pom.xml
Brijeshthummar02
force-pushed
the
10.21.4
branch
from
1ff99b9 to
c58f5ca
Compare
|
|
@romani i have squash the commit ad made several PRs which covers all updates, have a look to it. |
3 participants
fixes #546 , (also fixes #545 and #544)