fix css, add parameter position, set default icon#124
Open
gpibarra wants to merge 6 commits intocheesegrits:v3from
Open
fix css, add parameter position, set default icon#124gpibarra wants to merge 6 commits intocheesegrits:v3from
gpibarra wants to merge 6 commits intocheesegrits:v3from
Conversation
Owner
|
@gpibarra hey, sorry about the slow response, I've had some serious medical issues this year that prevented me from working on this. Could you update the README to document your changes, including a link to the relevant Google Maps doc page with the available button positions. Then I'll merge this. |
Contributor
Author
|
Hi @cheesegrits, sorry for my English, in the commit e5d29d4 I had already modified the documentation, do you want me to give more details? |
Contributor
Author
|
@cheesegrits have you seen this PR? |
shootkiran
approved these changes
May 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the
geolocatemethod, thegeolocateLabeldid not load the button's css correctly.If the label is empty, add the button with a default icon (svg).
Also, add the
Positionparameter to define where on the map the new button is added.