Skip to content

Comments

fix css, add parameter position, set default icon#124

Open
gpibarra wants to merge 6 commits intocheesegrits:v3from
gpibarra:fixCurrentLocationButton
Open

fix css, add parameter position, set default icon#124
gpibarra wants to merge 6 commits intocheesegrits:v3from
gpibarra:fixCurrentLocationButton

Conversation

@gpibarra
Copy link
Contributor

When using the geolocate method, the geolocateLabel did not load the button's css correctly.

If the label is empty, add the button with a default icon (svg).

Also, add the Position parameter to define where on the map the new button is added.

@cheesegrits
Copy link
Owner

@gpibarra hey, sorry about the slow response, I've had some serious medical issues this year that prevented me from working on this.

Could you update the README to document your changes, including a link to the relevant Google Maps doc page with the available button positions. Then I'll merge this.

@gpibarra
Copy link
Contributor Author

gpibarra commented Nov 15, 2024

Hi @cheesegrits, sorry for my English, in the commit e5d29d4 I had already modified the documentation, do you want me to give more details?

@gpibarra
Copy link
Contributor Author

@cheesegrits have you seen this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants