Group livewire updates and return 7 decimal places in lat lng#136
Open
iAmKevinMcKee wants to merge 1 commit intocheesegrits:v3from
Open
Group livewire updates and return 7 decimal places in lat lng#136iAmKevinMcKee wants to merge 1 commit intocheesegrits:v3from
iAmKevinMcKee wants to merge 1 commit intocheesegrits:v3from
Conversation
MACscr
added a commit
to Padmission/filament-google-maps
that referenced
this pull request
Oct 10, 2025
- Group Livewire updates using Promise.all for better performance - Return 7 decimal places for lat/lng coordinates using toFixed(7) - Add error handling for batch updates This integrates the improvements from cheesegrits#136 into the v4 codebase from cheesegrits#160 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
MACscr
added a commit
to Padmission/filament-google-maps
that referenced
this pull request
Oct 10, 2025
Compiled the JavaScript changes to include: - Batched Livewire updates using Promise.all - 7 decimal place precision for lat/lng - Fixed undefined $path error 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Author
|
@cheesegrits do you mind reviewing this? We are using our own fork due to this, I think it would be pretty simple for you to review. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now when geocompleting, every field is a different livewire request. This puts all the livewire requests together for a much faster experience.
Also, returning just 7 decimal in the lat lng, which gets you to 5 feet of precision. Could be 8, but any more than that I think is too much. Most people are not storing more than 7 or 8 decimals in their DB.