Open
Conversation
Signed-off-by: Ben Konick <bkonick@cargurus.com>
tas50
reviewed
Jul 7, 2019
| end | ||
|
|
||
| # TODO: fix idempotency for org admins | ||
| org_admins = JSON.parse( |
Contributor
There was a problem hiding this comment.
This really shouldn't be done by parsing knife. That's going to be super problematic and brittle. You'll want to hit the server API directly and parse out that output from there.
Contributor
Author
There was a problem hiding this comment.
Fair enough. I was sort of following the pattern of parsing output in some other parts of the same resource but I'll rework it to hit the API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes idempotency for admins in the chef_org resource. It uses
knife showto get the list of users in the admin group for a given org.Check List