Kyle/py6 #7
Draft
Kyle/py6 #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chef-kyle
commented
Jun 17, 2025
| moveit_planning_scene_interface | ||
| moveit_move_group_interface | ||
| moveit_py_bindings_tools | ||
| # moveit_py_bindings_tools_py${PYTHON_VERSION_MAJOR}${PYTHON_VERSION_MINOR} |
There was a problem hiding this comment.
I can't figure out the proper syntax to export this, but we don't need to anyhow
chef-kyle
commented
Jun 17, 2025
|
|
||
| set_target_properties(${MOVEIT_LIB_NAME} PROPERTIES VERSION "${${PROJECT_NAME}_VERSION}") | ||
| target_link_libraries(${MOVEIT_LIB_NAME} ${catkin_LIBRARIES} ${Boost_LIBRARIES} ${PYTHON_LIBRARIES}) | ||
| set_target_properties(${MOVEIT_LIB_NAME} PROPERTIES OUTPUT_NAME moveit_py_bindings_tools_py${PYTHON_VERSION_MAJOR}${PYTHON_VERSION_MINOR}.so ) |
There was a problem hiding this comment.
If we remove the boost::python dev from this library, we likely don't need to rename it
chef-kyle
commented
Jun 17, 2025
| ) | ||
|
|
||
| find_package(PythonInterp REQUIRED) | ||
| find_package(PythonInterp ${CHEF_FORCE_PYTHON_VERSION} REQUIRED) |
There was a problem hiding this comment.
FORCE_PYTHON_VERSION isn't strictly necessary, but helps make it obvious when you need to wipe the build dir
chef-kyle
commented
Jun 17, 2025
|
|
||
| find_package(Eigen3 REQUIRED) | ||
| find_package(eigenpy REQUIRED) | ||
| # TODO: probably need different eigenpy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you made, including a reference to the related issue if applicable
Checklist