-
Notifications
You must be signed in to change notification settings - Fork 43
Rebasing to new baseline OSS policies #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ware Corporation.
…e; changing reference from "project owners" to advisors.
… terms with respect to Decider and Community Organizers.
…n the page's TOC. Fixing.
…onvey any rights over trademarks or logo marks.
…ss of whether the downstream distriution is commercialized or offered for free use.
…tency; other cleanup.
…ader from "ready" pages
| name: Deploy docs | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout master | ||
| uses: actions/checkout@v1 | ||
|
|
||
| - name: Deploy docs | ||
| uses: mhausenblas/mkdocs-deploy-gh-pages@master | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| CONFIG_FILE: mkdocs.yml | ||
| #EXTRA_PACKAGES: build-base | ||
| # GITHUB_DOMAIN: github.myenterprise.com | ||
| REQUIREMENTS: /requirements.txt No newline at end of file |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 4 months ago
The best way to fix the problem is to add a permissions block to the workflow, either at the root level (applying to all jobs), or at the job-level (applying only to build). For minimal change and clarity, add it just above the build job if you only want it affecting this job. For deploying to GitHub Pages, the deployment action (mkdocs-deploy-gh-pages) almost always needs contents: write permission to push the generated documentation to the gh-pages branch. Therefore, the permissions block should be:
permissions:
contents: writeInsert this block either at the top level (just under name/on), or indented under the build: job (best practice: put it at the job level to scope it tightly). So in this snippet, add under line 9, before line 10, properly indented.
-
Copy modified lines R10-R11
| @@ -7,6 +7,8 @@ | ||
|
|
||
| jobs: | ||
| build: | ||
| permissions: | ||
| contents: write | ||
| name: Deploy docs | ||
| runs-on: ubuntu-latest | ||
| steps: |
This PR contains updates to the OSS practices and policies documentation, including:
Please review the changes and provide feedback.