Remove active support, it does not seem to be used#349
Merged
Conversation
tpowell-progress
approved these changes
Oct 28, 2025
Signed-off-by: Phil Dibowitz <phil@ipom.com>
jaymzh
force-pushed
the
nuke-activesupport
branch
from
09bedfc to
64795a4
Compare
|
11 tasks
TvdW
added a commit
to TvdW/chef-zero
that referenced
this pull request
Mar 8, 2026
The unf_ext dependency was added in PR chef#334 but is never actually used anywhere in the codebase - there are no require statements or usage of UNF:: classes. This dependency causes problems for JRuby users because unf_ext is a native C extension that cannot be compiled on JRuby. Since the dependency is unused, removing it restores JRuby compatibility. If Unicode normalization is ever needed, Ruby 3.1+ provides built-in String#unicode_normalize. Similar to PR chef#349 which removed unused activesupport dependency. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Tom van der Woerdt <info@tvdw.eu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Phil Dibowitz phil@ipom.com