Skip to content

CHEF-5815: Update signing method for msi packages (uses smctl now) #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ahasunos wants to merge 13 commits into
base: main
Choose a base branch
from
Open

CHEF-5815: Update signing method for msi packages (uses smctl now) #246

ahasunos wants to merge 13 commits into from

Conversation

@ahasunos
Copy link

@ahasunos ahasunos commented Sep 14, 2023 •
edited
Loading

Description

This PR updates the signing_identity invocation with the latest required parameters as per the smctl signing tool introduced in omnibus.

Related Issue

CHEF-5815: Digicert - renew license and implement HSM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@ahasunos ahasunos requested review from a team as code owners September 14, 2023 15:27
@ahasunos ahasunos force-pushed the ss/update-signing-identity-method-omnibus-toolchain branch from c966ea1 to 334100c Compare September 14, 2023 15:44
@sean-sype-simmons sean-sype-simmons mentioned this pull request Sep 14, 2023
Closed
10 tasks
dependabot bot and others added 3 commits September 25, 2023 13:34
@dependabot
Bump omnibus from d6d4b0d to 56015cb
0674542 
Bumps [omnibus](https://github.com/chef/omnibus) from `d6d4b0d` to `56015cb`.
- [Release notes](https://github.com/chef/omnibus/releases)
- [Commits](chef/omnibus@d6d4b0d...56015cb)

---
updated-dependencies:
- dependency-name: omnibus
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@poorndm
Merge pull request #248 from chef/dependabot/bundler/omnibus-56015cb
0e5b68c 
Bump omnibus from `d6d4b0d` to `56015cb`
@chef-ci
Bump version to 3.0.18 by Chef Expeditor
1f1db6f 
Obvious fix; these changes are the result of automation not creative thinking.
@ahasunos ahasunos mentioned this pull request Sep 26, 2023
Open
10 tasks
@sean-sype-simmons sean-sype-simmons requested a review from a team as a code owner October 3, 2023 11:43
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sean-sype-simmons
Copy link
Contributor

sean-sype-simmons commented Oct 5, 2023 •
edited
Loading

we should clean this up, and then we can merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poorndm poorndm poorndm approved these changes

@sean-sype-simmons sean-sype-simmons Awaiting requested review from sean-sype-simmons

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ahasunos @sean-sype-simmons @poorndm @chef-ci