Merged
Conversation
johnmccrae
added
the
Expeditor: Bump Version Minor
tpowell-progress
requested changes
Jun 3, 2025
tpowell-progress
left a comment
tpowell-progress
left a comment
There was a problem hiding this comment.
Not sure about the [presumably performance] deep nesting of ifs.
tpowell-progress
approved these changes
Jun 5, 2025
neha-p6
requested changes
Jun 24, 2025
tpowell-progress
approved these changes
Jun 24, 2025
tpowell-progress
left a comment
tpowell-progress
left a comment
There was a problem hiding this comment.
A couple of cleanup items suggested.
Signed-off-by: John McCrae <john.mccrae@progress.com>
johnmccrae
force-pushed
the
jfm/ruby-version-change
branch
from
90d872e to
5c7bccd
Compare
Signed-off-by: John McCrae <john.mccrae@progress.com>
Signed-off-by: John McCrae <john.mccrae@progress.com>
Signed-off-by: John McCrae <john.mccrae@progress.com>
Signed-off-by: John McCrae <john.mccrae@progress.com>
Signed-off-by: John McCrae <john.mccrae@progress.com>
Signed-off-by: John McCrae <john.mccrae@progress.com>
Signed-off-by: John McCrae <john.mccrae@progress.com>
Signed-off-by: John McCrae <john.mccrae@progress.com>
|
rishichawda
approved these changes
Jun 30, 2025
muthuja
approved these changes
Jun 30, 2025
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: [windows-2022, windows-2025] |
There was a problem hiding this comment.
i think we are not yet supporting windows-2025 in our infrastructure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We are moving to Ruby 3.4 and Cookstyle for Chef-19. This gem has not been updated in quite some time. We're ensuring compatibility here.
We also updated a couple of tests as they were failing under Ruby 3.1/3.4
The install_ruby.ps1 file is a bit of slog. What we found during extensive testing was that the images were pretty polluted with multiple copies of Ruby installed at the root as part of the image but also installed via Choco. Tests were failing because the ucrt libraries were way out of whack and didn't match the Ruby version. We ended needing to take a kind of scorched earth approach and remove everything that smelled like Ruby or MSYS
Issues Resolved
[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant]
Check List