Conversation
chellmuth
commented
Feb 4, 2025
| std::string& value) const | ||
| { | ||
| return false; | ||
| } |
Owner
Author
There was a problem hiding this comment.
The external cache API. Should the names include "optix" or be generic?
chellmuth
commented
Feb 4, 2025
| std::ostringstream out; | ||
| out.imbue(std::locale::classic()); // force C locale | ||
| out.precision(9); | ||
| lock_guard lock(m_mutex); |
Owner
Author
There was a problem hiding this comment.
This lock caused me some trouble. ShadingSystemImpl::optimize_group grabs the same lock, and then calls serialize, so we deadlock without a change.
This is a quick fix, a recursive mutex would be another. I don't understand the locking scheme well enough to know the right call here.
chellmuth
commented
Feb 4, 2025
| optix_cache_unwrap(const std::string& cache_value, std::string& ptx, | ||
| size_t& groupdata_size); | ||
| std::string | ||
| optix_cache_wrap(const std::string& ptx, size_t groupdata_size); |
Owner
Author
There was a problem hiding this comment.
Wasn't sure where to put these functions. They should be paired up, but one is used in llvm_instance and the other in shadingsys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tests
Checklist:
already run clang-format v17 before submitting, I definitely will look at
the CI test that runs clang-format and fix anything that it highlights as
being nonconforming.