feat: implement axis unit picker behind experimental flag#4054
Merged
feat: implement axis unit picker behind experimental flag#4054
Conversation
`ContextMenu` seems not mix well in svg
Deploying nmrium with
|
| Latest commit: |
2577c8d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f45b91f8.nmrium.pages.dev |
| Branch Preview URL: | https://4040-choose-unit-on-axis-and.nmrium.pages.dev |
* implement onChange with all needed actions for the reducer
tpoisseau
changed the title
Contributor
Author
|
@hamed-musallam I suggest you to take a look to this PR because I suppose you will implement the scales unit conversion later. |
targos
reviewed
Mar 12, 2026
targos
reviewed
Mar 12, 2026
targos
approved these changes
Mar 12, 2026
* use default values from core for `defaultUnit2DNucleus` Refs: #4054 (comment) Refs: #4054 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right click on unit label open a menu to select a unit.
It's implemented for
HorizontalAxis1D,DirectAxis2DandIndirectAxis2D.IndirectAxis2Dstill takes care ofmaybeNucleusUnit. If it does notmatchNucleusshowmaybeNucleusUnitwithout the unit picker (fixed unit).each unit picker takes care of axis constraints (
isFt/isFid) to show allowed options.Refs: #4040
Unit conversion should be done in another PR by another one.