post-fs-data.sh: Create directories with mkdir -p#172
Merged
chenxiaolong merged 1 commit intochenxiaolong:masterfrom Feb 3, 2026
Merged
post-fs-data.sh: Create directories with mkdir -p#172chenxiaolong merged 1 commit intochenxiaolong:masterfrom
chenxiaolong merged 1 commit intochenxiaolong:masterfrom
Conversation
chenxiaolong
approved these changes
Feb 3, 2026
Owner
chenxiaolong
left a comment
There was a problem hiding this comment.
Oof, that was a dumb oversight on my part.
Thanks for the PR!
Owner
|
The CI failing is unrelated to your change. It's due to a vulnerability in a dependency. I'll update the dependencies in a separate PR and then rebase this branch. EDIT: "unrelated", not "related" |
`$mnt_dir` was not created with `mkdir -p`, unlike `$mnt_base`. This caused the system-ca-certs module to only work for the first boot after it was enabled, since `mkdir` would fail on subsequent boots.
a9e7385 to
07c7091
Compare
chenxiaolong
added a commit
that referenced
this pull request
Feb 3, 2026
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$mnt_dirwas not created withmkdir -p, unlike$mnt_base. This caused the system-ca-certs module to only work for the first boot after it was enabled, sincemkdirwould fail on subsequent boots.Log: