Skip to content

Dev/qdrant update#1059

Merged
pieroit merged 3 commits intocheshire-cat-ai:developfrom
nickprock:dev/qdrant_update
Apr 7, 2025
Merged

Dev/qdrant update#1059
pieroit merged 3 commits intocheshire-cat-ai:developfrom
nickprock:dev/qdrant_update

Conversation

@nickprock
Copy link
Copy Markdown
Contributor

Description

Qdrant has changed the name and operation of some APIs in recent versions, in particular:

  • recreate_collection --> create_collection
  • search --> query_points

In the second case, the parameter names and output format have also changed. They will be deprecated in the future so it is better to update the code now without coming up short.

I have run the tests and the success rate is 100%. I also did some testing on the admin and there should be no problem,

I can't guarantee backward compatibility with ALL plugins.

Related to issue #1053

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

astrogatto

@nickprock
Copy link
Copy Markdown
Contributor Author

@pieroit I should get it right this time

@pieroit
Copy link
Copy Markdown
Member

pieroit commented Apr 7, 2025

@pieroit I should get it right this time

@nickprock sorry I still see a commit to the Dockerfile, there should be no edits to it.
Are you seure your develop branch is up to date?

Sorry for being picky I'm grateful, but if I merge this, at the next release I need to recommit on main the changes that you are undoing on the Dockerfile

@nickprock
Copy link
Copy Markdown
Contributor Author

nickprock commented Apr 7, 2025

Are you seure your develop branch is up to date?

Yes, I have aligned the develop branch before to create the new branch

@nickprock
Copy link
Copy Markdown
Contributor Author

I try a very dirty solution.

@pieroit pieroit merged commit 086778c into cheshire-cat-ai:develop Apr 7, 2025
2 checks passed
@pieroit
Copy link
Copy Markdown
Member

pieroit commented Apr 7, 2025

Thanks :*

@nickprock nickprock deleted the dev/qdrant_update branch June 13, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants