Analysis: Factory object collection timing - bootstrap vs per-request#1108
Closed
Analysis: Factory object collection timing - bootstrap vs per-request#1108
Conversation
Copilot
AI
changed the title
[WIP] Review object collection strategy in factory.py
Analysis: Factory object collection timing - bootstrap vs per-request
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analyzed
factory.pyto determine optimal timing for plugin object collection (LLMs, agents, auth handlers, MCP servers).Current Implementation (Correct ✅)
Objects are collected at app bootstrap via
on_mad_hatter_refresh()callback:Per-request access is lightweight:
Recommendation: Keep at Bootstrap
Performance: Avoids executing
mad_hatter.execute_hook()(iterates all plugins) on every requestArchitecture:
_ccatRefresh triggers: App start, plugin toggle, hot reload (infrequent vs requests)
No Changes Required
Current implementation follows FastAPI best practices for plugin-based apps.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.