Open
Conversation
Member
|
Thx for the contribution! For me is ok but i would prefer to have a central module to store all classes like this one. What do you think @pieroit ? |
pieroit
requested changes
Nov 1, 2024
Member
|
@scicco sorry for the delay, left some suggestions. Let me know if you can do it or I'll try |
Author
|
No problem, I'll work on that |
97cc8c3 to
ad5f3b5
Compare
Author
|
Hello @pieroit, I've implemented the changes. If something should be changed or fixed, let me know, and I'll do it. Thank you |
ad5f3b5 to
2006338
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is my first attempt to try to contribute a bit to this awesome project😹
This commit will lower the recall threshold. It also separates the config introducing the
RecallSettingsclass as suggested in TODOI've set the following constant values:
please let me know if those values are appropriate.
Related to issue (#909)
Type of change
Checklist: