Merged
Conversation
kanru
reviewed
Mar 5, 2025
Member
|
Ouch, CI broke due to recent rustup update. I'll fix it tomorrow. |
Contributor
Author
|
Should Colemak always be below Workman? |
Member
The numerical mapping only matters for C interface compatibility. For the enum in code we can group them together. |
Contributor
Author
|
The tests say that the return value of chewing_KBStr2Num is wrong I think? |
kanru
reviewed
Mar 7, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #674 +/- ##
==========================================
+ Coverage 89.85% 89.86% +0.01%
==========================================
Files 42 43 +1
Lines 8763 8775 +12
==========================================
+ Hits 7874 7886 +12
Misses 889 889 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kanru
approved these changes
Mar 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR I tried adding Colemak as a keyboard layout.
After a recent
sudo pacman -Syu, Arch Hyprland seemed to have realized my default keyboard is colemak, which is great, except for the fact that bopomofo is now all out of whack.I found this:
https://blog.louie.lu/2024/11/15/colemak-dh-keyboard-layout-and-bopomofo-input/
so I'll see if I can do the same with just colemak.
Tests seem to be gitignored, so I'm not sure if I should write one.