Skip to content

feat: Adding Colemak#674

Merged
kanru merged 9 commits intochewing:masterfrom
New9c:add-colemak
Mar 8, 2025
Merged

feat: Adding Colemak#674
kanru merged 9 commits intochewing:masterfrom
New9c:add-colemak

Conversation

@New9c
Copy link
Contributor

@New9c New9c commented Mar 5, 2025

TLDR I tried adding Colemak as a keyboard layout.

After a recent sudo pacman -Syu, Arch Hyprland seemed to have realized my default keyboard is colemak, which is great, except for the fact that bopomofo is now all out of whack.
I found this:
https://blog.louie.lu/2024/11/15/colemak-dh-keyboard-layout-and-bopomofo-input/
so I'll see if I can do the same with just colemak.
Tests seem to be gitignored, so I'm not sure if I should write one.

@New9c New9c changed the title Adding Colemak feat: Adding Colemak Mar 5, 2025
@kanru
Copy link
Member

kanru commented Mar 5, 2025

Ouch, CI broke due to recent rustup update. I'll fix it tomorrow.

@New9c
Copy link
Contributor Author

New9c commented Mar 6, 2025

Should Colemak always be below Workman?
For future maintaining sake?

@kanru
Copy link
Member

kanru commented Mar 6, 2025

Should Colemak always be below Workman? For future maintaining sake?

The numerical mapping only matters for C interface compatibility. For the enum in code we can group them together.

@New9c
Copy link
Contributor Author

New9c commented Mar 6, 2025

The tests say that the return value of chewing_KBStr2Num is wrong I think?
I don't quite get it, I believe I've set Colemak as the 16th layout.

@codecov
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (2d0cdd7) to head (724214b).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #674      +/-   ##
==========================================
+ Coverage   89.85%   89.86%   +0.01%     
==========================================
  Files          42       43       +1     
  Lines        8763     8775      +12     
==========================================
+ Hits         7874     7886      +12     
  Misses        889      889              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kanru kanru added this to the v0.10.0 milestone Mar 8, 2025
@kanru kanru added this pull request to the merge queue Mar 8, 2025
Merged via the queue into chewing:master with commit 1232dcf Mar 8, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants