build: remove unused swift plugin file and update error message#793
build: remove unused swift plugin file and update error message#793
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #793 +/- ##
=======================================
Coverage 92.06% 92.06%
=======================================
Files 37 37
Lines 9253 9253
=======================================
Hits 8519 8519
Misses 734 734 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
I think we need to add this Provide libchewing as a Swift package with the exposures of C_based APIs only. instead. This ensures that no one expects Swiftified APIs from this package (which brings extra burden to this repo). If anyone wants Swiftified APIs, he / she can make them by himself / herself.
NEWS
Outdated
| - New boolean config option `chewing.sort_candidates_by_frequency` can be | ||
| set to enable sorting candidates by frequency. | ||
| - Rust type SyllableSlice is removed from public interfaces. | ||
| - Provide libchewing as a Swift package. |
There was a problem hiding this comment.
- Provide libchewing as a Swift package with the exposures of C_based APIs only.
There was a problem hiding this comment.
Make sense. For me libchewing refers only to the C API but your edit makes it more clear for people unfamiliar with the history of libchewing.
0e68b76 to
036d4c3
Compare
See also #790 (comment)
Thanks to @ShikiSuen