Avoid multiple interceptor instances due factory #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced anonymous factory by named factory for better caching and reusage in the $injector service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue is this PR resolving? Alternatively, please describe the bugfix/enhancement this PR aims to provide
Replaced anonymous factory by named factory for better caching and reuse in the $injector service.
We had problems with protractor-http-mock where the interceptor was instantiated multiple times due the anonymous factory and caused timeouts in protractor.
Have you provided unit tests that either prove the bugfix or cover the enhancement?
I've checked the tests and nothing breaks. If you know how to test it, I will to my very best to create one.
Related issues