Conversation
✅ Deploy Preview for sprightly-muffin-751ffc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for creative-quokka-61f1f5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
.github/workflows/download-data.yml
Outdated
|
|
||
| jobs: | ||
| download-data-json: | ||
| runs-on: macos-latest |
There was a problem hiding this comment.
May I know the context around the choice for running on macos instead of ubuntu?
There was a problem hiding this comment.
macos runners have 14 GB of RAM, but ubuntu only has 7. https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners. This was an issue for one of the backend jobs, but ubuntu might be fine for this one.
There was a problem hiding this comment.
I have no concerns with macos. I was just concerned about whether we were running up against some memory limits that we might some day exceed again.
.github/workflows/download-data.yml
Outdated
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - run: | | ||
| wget https://chn-ghost-buses-public.s3.us-east-2.amazonaws.com/frontend_data_files/data.json \ |
There was a problem hiding this comment.
Currently the backend is uploading files to s3 at cta_schedule_zipfiles_raw/google_transit_{today}.zip. Is there a plan that the backend GitHub Action will be uploading updated json data at frontend_data_files/data.json and schedule_vs_realtime_all_day_types_routes.json? I see several backend PRs. Are there particular PRs I should focus on in the backend repo in order to understand what the files in s3 will consist of?
There was a problem hiding this comment.
Thanks for the clarification. In this case, I'm ready to approve. Shall we convert to draft first so that we don't merge before chihacknight/chn-ghost-buses#69 is merged, or will we just remember the proper sequence of merging?
There was a problem hiding this comment.
Thanks, converting to a draft would be a good idea. I'll do that.
dcjohnson24
changed the base branch from
main
to
update-schedule-performance-data
dcjohnson24
changed the base branch from
update-schedule-performance-data
to
main
Co-authored-by: dcjohnson24 <dcjohnson24@gmail.com>
3 participants
Description
Download
data.jsonandschedule_vs_realtime_all_day_types_routes.jsonfrom s3. Commit the changes to GitHub.Checklist
Screenshots