fix(113) adjust location of annotation; shrink x axis range if screen…#121
Open
robertmiddlekauff wants to merge 2 commits intochihacknight:mainfrom
Open
fix(113) adjust location of annotation; shrink x axis range if screen…#121robertmiddlekauff wants to merge 2 commits intochihacknight:mainfrom
robertmiddlekauff wants to merge 2 commits intochihacknight:mainfrom
Conversation
… is small; format axis and tooltip
✅ Deploy Preview for creative-quokka-61f1f5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for sprightly-muffin-751ffc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Collaborator
|
@robertmiddlekauff Thank you for this fix! To ask a quick question: is the shift from "normal" to "compact" mode meant to happen dynamically as one resizes, or is the intended behavior that the shift occurs only with a refresh. When doing some testing, I was able to see exactly the desired behavior you screenshotted, but only when I performed a refresh. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adjust location of annotation; shrink x axis range if screen is small; format axis and tooltip
Description
This PR seeks to address issue 113: #113
This PR limits the amount of data that is shown on smaller screens because there are simply too many data points to display with the current data setup. The user can still scroll left if they know the chart well, but I am making an assumption about a mobile user that they just want to see the last 12 months and don't necessarily need to see the full dataset.
It also formats the axis to be percentage bc even though it's calculated as a ratio it's really a percentage of the total trips. This will make it slightly easier to process what the chart means.
I also adjusted the location of the annotation to account for these changes and make the data on the chart bigger and reduce whitespace.
Checklist
Screenshots
|
|
|
|