Conversation
dcjohnson24
left a comment
dcjohnson24
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for this. I just had a question about changing the target branch to main.
| with: | ||
| file-path: schedule_vs_realtime_all_day_types_routes.json No newline at end of file | ||
| file-path: schedule_vs_realtime_all_day_types_routes.json | ||
| - uses: oleksiyrudenko/gha-git-credentials@v2-latest |
There was a problem hiding this comment.
I noticed that this generates a warning about updating to Node 20. I don't know if there is a later version for this action, but maybe line 15 could be changed to actions/checkout@v4?
There was a problem hiding this comment.
@dcjohnson24 I have upgraded checkout to version 4, but I am still getting a warning for gha-git-credentials. Unfortunately, there is not a newer version of this action. I can make a PR to that repo, but in the meantime I suggest living with the warning in our repo.
There was a problem hiding this comment.
@dcjohnson24 I made a PR in the github action to upgrade to version 20 here.
There was a problem hiding this comment.
Thanks for looking into this and submitting the PR. I agree that we can live with the warning.
…uses-frontend into save-ridership-file Add the file committed by GitHub action.
KyleDolezal
force-pushed
the
save_downloaded_files
branch
from
756ce09 to
c0f3a1f
Compare
Save ridership file
2 participants
Save the files that are downloaded from S3 so they are accessible when running the frontend project in a browser.