Replace insta CLI tests with dual-mode VHS snapshot testing#15
Draft
Replace insta CLI tests with dual-mode VHS snapshot testing#15
Conversation
Remove api_snaps.rs (dead code referencing nonexistent path), cli_example_snaps.rs, and their associated .snap files. Keep wizard_tests.rs (pure unit tests). VHS tapes now run in two modes via TEST_MODE env var: - mock: diffs output against committed expected files (PR, fast) - prod: smoke tests output is non-empty (nightly, live data) Add TESTING.md documenting data lineage, testing tiers, and the dual-mode approach. Add govbot mock schema validation to CI. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…nism jwalk parallel filesystem traversal produces different ordering on macOS vs Linux. Sort both actual and expected before comparing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
api_snaps.rs,cli_example_snaps.rs) and their.snapfiles. Wizard unit tests stay.TEST_MODEenv var:mockdiffs output against committed expected files,prod(default) smoke-tests non-empty output.mocks/, skips clone, runslogs | tag+build.validate-snapshots.yml.TESTING.mddocumenting data lineage, testing tiers, and how to run/update everything.Test plan
cargo testpasses (12 wizard tests)TEST_MODE=mock vhs tapes/*.tape)terminal-screenshots.ymlpasses (Generate Terminal GIFs - Mock Mode)validate-snapshots.ymlpasses (govbot-snapshots + Validate Govbot Mock Data)synthetic-test.ymlpasses (Govbot Wizard & Pipeline)🤖 Generated with Claude Code