Open
Conversation
Signed-off-by: Unix-Code <dmalakh@comcast.net>
Signed-off-by: Unix-Code <dmalakh@comcast.net>
Signed-off-by: Unix-Code <dmalakh@comcast.net>
…ctors-and-departments Restoring changes made in this branch
* fixed project layout * flask-sqlalchemy -> sqlalchemy * removed comment * fixed model init + report service cleanup
* fixed pipeline code to not be totally screwed up * added pipeline requirements file
* moved elasticsearch out of create_app + all controllers now use responsify instead of jsonify (easier to change later)
* responsify dynamically wraps arrays in {data: ...} but not objects
* add app environment to serverless config * changelog
…ttps://github.com/chilipot/TRACE-API into feature/add-question-categories # Conflicts: # api/controller/report_controller.py + added faceting by category id for questions text endpoint
[#27] Adding Question Categories
Add Gitter Badge
* fixed missing scoredata-report rel to be not found case + moved logic for scoredata as_dict to result of report service func + added categories for term logic * Added category-answers relationship & logic * disable lookup_answer collapse in response * add individual response + save individual response endpoint
danguddemi
reviewed
Sep 6, 2019
|
|
||
| @staticmethod | ||
| def _dict_or_collapsed(obj): | ||
| def _dict_or_collapsed(obj, models_hit=[]): |
Collaborator
There was a problem hiding this comment.
Mutable default arguments are bad.
This works better. You could also use an if conditional
def _dict_or_collapsed(obj, models_hit=None): models_hit = models_hit or []
danguddemi
reviewed
Sep 6, 2019
|
|
||
| course = relationship('Course', back_populates='score_data', uselist=False) | ||
| questions = relationship('Question', back_populates='score_data') | ||
|
|
Collaborator
There was a problem hiding this comment.
How are you serializing objects now?
danguddemi
approved these changes
Sep 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.