-
Notifications
You must be signed in to change notification settings - Fork 0
3. Code Review
Jake edited this page Apr 2, 2018
·
3 revisions
Code reviews are performed to ensure code quality.
- Code Review Requested (PR)
- Read user story/requirement for this PR
- Pull up the PR on GitHub and review what has changed
- Green was added
- Red was removed
- Pull down the changes onto your localhost
- boy scout - old crap fixed too?
- mobile - does it work on mobile? how does it look?
- Test code meets Issue/Task requirements
- npm run lint
- npm run test
- Test on mobile view
- Finish review (approve, request changes, reject)
- visually do a code review of what has changed ()
- if code looks okay, pull down branch locally
- test locally: does work completed match the Issue's Requirements?
- Test in mobile view
- PR Review: Approve if all is met Request changes Reject (?)
If approved and merged, Delete branch (if needed)
Code Review: Is anything hard coded? Functional (vs imperative)? Does it follow coding standards? Are there unit tests written? Ask questions!