Skip to content

3. Code Review

Jake edited this page Apr 2, 2018 · 3 revisions

Currently this is a ROUGH DRAFT!

Code reviews are performed to ensure code quality.

Code Review

  1. Code Review Requested (PR)
  2. Read user story/requirement for this PR
  3. Pull up the PR on GitHub and review what has changed
    1. Green was added
    2. Red was removed
  4. Pull down the changes onto your localhost
    1. boy scout - old crap fixed too?
    2. mobile - does it work on mobile? how does it look?
  5. Test code meets Issue/Task requirements
    1. npm run lint
    2. npm run test
  6. Test on mobile view
  7. Finish review (approve, request changes, reject)

Overview:

  1. visually do a code review of what has changed ()
  2. if code looks okay, pull down branch locally
  3. test locally: does work completed match the Issue's Requirements?
  4. Test in mobile view
  5. PR Review: Approve if all is met Request changes Reject (?)

If approved and merged, Delete branch (if needed)

Code Review: Is anything hard coded? Functional (vs imperative)? Does it follow coding standards? Are there unit tests written? Ask questions!

Clone this wiki locally