Added a bugs section and added the bug in pd.merge() #7
Closed
umeshG34 wants to merge 2 commits intochiphuyen:masterfrom
Closed
Added a bugs section and added the bug in pd.merge() #7umeshG34 wants to merge 2 commits intochiphuyen:masterfrom
umeshG34 wants to merge 2 commits intochiphuyen:masterfrom
Conversation
umeshG34
changed the title
chiphuyen
requested changes
Nov 19, 2020
Owner
chiphuyen
left a comment
chiphuyen
left a comment
There was a problem hiding this comment.
Thanks for contributing! There are several comments in the PR, but here are two major ones:
- Can you make it into 2 separate PRs since they do different things: one for typos and the other for adding the known bugs?
- Try not to re-run cells that you didn't update to avoid overwriting the existing results.
Cheers,
| "source": [ | ||
| "---\n", | ||
| "## 7. Bugs\n", | ||
| "### 7.1 `pd.merge()` joins over np.nan and None\n", |
Owner
There was a problem hiding this comment.
nit: escape np.NaN and None for consistency
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
7. Bugssection and added7.1 pd.merge() joins over np.nan and Noneas the first bug.Please review and let me know of any changes you would like me to make.
Thank you!