Open
Conversation
Disable DTB discovery, which was introduced in riscv-software-src/riscv-isa-sim@2c94ea4
BilalAli10x
approved these changes
Mar 31, 2026
BilalAli10x
left a comment
BilalAli10x
left a comment
There was a problem hiding this comment.
I verified this fix locally. Adding the false argument to the sim_t constructor is required for compatibility with the latest Spike. My riscv-vector-tests build is now passing Stage 1 and Stage 2 with this change.
Contributor
|
Could you update the hash and pull the latest? Since then, two new vector extensions, Zvabd and Zvzip, have been added (not yet ratified) to Spike, along with a fix to the RVV Crypto group. |
Author
|
Sure! I checked locally, and no other API changes seem to have occured. |
nadime15
approved these changes
Mar 31, 2026
Collaborator
|
There are failures in the RV64_Zvl64 combo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable DTB discovery, which was introduced in riscv-software-src/riscv-isa-sim@2c94ea4