[VeriblePreProcessor][2]: Positional arguments to pass defines and inclusion directories.#1373
[VeriblePreProcessor][2]: Positional arguments to pass defines and inclusion directories.#1373karimtera wants to merge 10 commits intochipsalliance:masterfrom
Conversation
…o generate all variants with the new mode generate-variants
…ass for the moment.
"verible::CmdPositionalArguments" class only supports these types so far: SV files, +define+<name>[=<value>], and +incdir+<dir>.
hzeller
left a comment
There was a problem hiding this comment.
I think if we use your code to parse things into a struct FileList (and add a container in there for the defines), we have a good starting point to use it for all tools.
- Using FileList in the preprocessor tool instead of CmdPositionalArguments.
hzeller
left a comment
There was a problem hiding this comment.
Nice. Make sure to add a unit test. Also, use absl::string_view where possible, avoid std::string unless you actually need a copy of the data.
|
Here the first start would of course to rebase to current head. But since there are a lot of changes that you essentially have to integrate, and this one is a somewhat independent (just the commandline changes), it might be easier if you start a fresh pull request: you just copy over the Up to you. |
|
That would be easier, I am on it. |
NOTE: This is a part of the sequentially splitted PRs from PR #1360.
Description:
This PR implements a class that handles positional arguments for the preprocessor tool.
Any of the following positional argument can be passed one or more times.
`define foo text`include "file_name"