Added an always_wrap_module_instantiations flag #1909
Open
jbylicki wants to merge 6 commits intochipsalliance:masterfrom
Open
Added an always_wrap_module_instantiations flag #1909jbylicki wants to merge 6 commits intochipsalliance:masterfrom
always_wrap_module_instantiations flag #1909jbylicki wants to merge 6 commits intochipsalliance:masterfrom
Conversation
Signed-off-by: Jan Bylicki <jbylicki@antmicro.com>
Signed-off-by: Jan Bylicki <jbylicki@antmicro.com>
Signed-off-by: Jan Bylicki <jbylicki@antmicro.com>
jbylicki
force-pushed
the
add-module-instantiation-wrapping-options
branch
from
f25c9f4 to
a5216a1
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #1909 +/- ##
==========================================
- Coverage 93.13% 92.82% -0.31%
==========================================
Files 355 355
Lines 25843 26132 +289
==========================================
+ Hits 24069 24258 +189
- Misses 1774 1874 +100
☔ View full report in Codecov by Sentry. |
Collaborator
|
Nice, can you update the Usage section in the README ? (I think at some point we should have a documentation section with examples in the README that demonstrates the result of all flags. For some later PR :) ). |
Signed-off-by: Jan Bylicki <jbylicki@antmicro.com>
mglb
suggested changes
Jun 26, 2023
Co-authored-by: Mariusz Glebocki <mglb@arccos-1.net> Signed-off-by: Jan Bylicki <jbylicki@antmicro.com>
jbylicki
force-pushed
the
add-module-instantiation-wrapping-options
branch
from
e0115e0 to
ea4656f
Compare
mglb
reviewed
Jun 29, 2023
Signed-off-by: Jan Bylicki <jbylicki@antmicro.com>
jbylicki
force-pushed
the
add-module-instantiation-wrapping-options
branch
from
ea4656f to
8f33d2d
Compare
mglb
approved these changes
Jul 4, 2023
hzeller
added
the
want-merge-needs-rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a new flag for the formatter:
always_wrap_module_instantiations.It forces module instantiations to be always split to new lines, instead of fitting it on line wherever possible. The default is set to
false, which does not change the behavior of the formatter.Fixes #1889
In there, the issue author suggested a two-state solution that I chose to implement.