Enable suspicious-semicolon_rule by default#2066
Open
IEncinas10 wants to merge 1 commit intochipsalliance:masterfrom
Open
Enable suspicious-semicolon_rule by default#2066IEncinas10 wants to merge 1 commit intochipsalliance:masterfrom
IEncinas10 wants to merge 1 commit intochipsalliance:masterfrom
Conversation
Collaborator
|
I'll defer approval here a bit as I first need to look through some of our script-generated code yet that produces this pattern. |
Collaborator
|
(still on it. I remember I looked used it on a bunch of DV files and there were some pattern that they used that triggered it, but didn't have time yet to look in detail) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This recently added rule inspired by a clang-tidy seems a good candidate for being enabled by default. Only one "possible" false positive, and could potentially save hours of staring at a screen (don't ask me how I know)