-
Notifications
You must be signed in to change notification settings - Fork 270
fixe #2278 #2312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fixe #2278 #2312
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| { | ||
| // Use IntelliSense to learn about possible attributes. | ||
| // Hover to view descriptions of existing attributes. | ||
| // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387 | ||
| "version": "0.2.0", | ||
| "configurations": [ | ||
| { | ||
| "name": "(gdb) Attach", | ||
| "type": "cppdbg", | ||
| "request": "attach", | ||
| "program": "enter program name, for example ${workspaceFolder}/a.exe", | ||
| "MIMode": "gdb", | ||
| "miDebuggerPath": "/path/to/gdb", | ||
| "setupCommands": [ | ||
| { | ||
| "description": "Enable pretty-printing for gdb", | ||
| "text": "-enable-pretty-printing", | ||
| "ignoreFailures": true | ||
| }, | ||
| { | ||
| "description": "Set Disassembly Flavor to Intel", | ||
| "text": "-gdb-set disassembly-flavor intel", | ||
| "ignoreFailures": true | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "name": "(Windows) Launch", | ||
| "type": "cppvsdbg", | ||
| "request": "launch", | ||
| "program": "enter program name, for example ${workspaceFolder}/a.exe", | ||
| "args": [], | ||
| "stopAtEntry": false, | ||
| "cwd": "${fileDirname}", | ||
| "environment": [], | ||
| "console": "externalTerminal" | ||
| } | ||
| ] | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,14 +35,16 @@ struct LintConfigParameterDescriptor { | |
| std::string description; | ||
| }; | ||
|
|
||
| struct LintRuleDescriptor { | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. where did this one go ? Looks like the end of the file was accidentally deleted ? |
||
| LintRuleId name; // ID/name of the rule. | ||
| absl::string_view topic; // section in style-guide | ||
| std::string desc; // Detailed description. | ||
| std::vector<LintConfigParameterDescriptor> param; | ||
| }; | ||
|
|
||
| } // namespace analysis | ||
| } // namespace verilog | ||
|
|
||
| #endif // VERIBLE_VERILOG_ANALYSIS_DESCRIPTIONS_H_ | ||
| std::string format_long_description(const std::string& description) { | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This needs a unit test. The naming convention for functions is typically CamelCase, so here
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if you pass in an absl::string_view, your operations below will be cheaper.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @hzeller okay sir again i do my best |
||
| const size_t max_length = 80; | ||
Bhavin-umatiya marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| std::string formatted_desc; | ||
| size_t start = 0; | ||
|
|
||
| while (start < description.size()) { | ||
| size_t end = std::min(start + max_length, description.size()); | ||
| formatted_desc += description.substr(start, end - start) + "\n "; | ||
Bhavin-umatiya marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| start = end; | ||
| } | ||
|
|
||
| return formatted_desc; | ||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.