Update bison.bzl and flex.bzl to work with Bazel 8#2452
Open
mneilly wants to merge 1 commit intochipsalliance:masterfrom
Open
Update bison.bzl and flex.bzl to work with Bazel 8#2452mneilly wants to merge 1 commit intochipsalliance:masterfrom
mneilly wants to merge 1 commit intochipsalliance:masterfrom
Conversation
The committers listed above are authorized under a signed CLA. |
Collaborator
|
Don't worry about the smoke tests, I'll take care of that. The windows build looks like it almost works, but there is a mysterious |
hzeller
reviewed
Aug 29, 2025
| native.genrule( | ||
| name = name + "_windows", | ||
| srcs = [src], | ||
| outs = [out + ".windows"], |
Collaborator
There was a problem hiding this comment.
ah, the suffix is not mysterious anymore. But looks like it messes with the rest of the build-system
Author
|
I'll take a look at the windows issue tomorrow. It shouldn't be difficult to resolve (I hope). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change modifies the bison.bzl and flex.bzl files to accommodate changes in Bazel 8 that disallow use of select in the toolchain attribute. Instead of select, multiple targets are created and the resulting files (unique per target) are copied to the expected location.
If anybody is aware of a better approach feel free to chime in.