Add restart retry limits to on-failure restart policy

[jacderida]

Summary

• Extends RestartPolicy::OnFailure with max_retries and reset_after_secs fields to prevent
  infinite restart loops using the generic cross-platform API
• Implements the feature for WinSW: generates multiple <onfailure> XML elements based on
  max_retries, with a final action="none" to stop after exhausting retries
• Other backends (systemd, launchd, sc, OpenRC, rc.d) have TODO placeholders for future
  implementation

Breaking change: RestartPolicy::OnFailure now requires two additional fields. Use None for
both to preserve previous behavior.

Test plan

• All 15 existing unit tests pass
• 6 new WinSW unit tests covering max_retries, reset_after_secs, combined usage, backwards
  compatibility, and precedence of WinSW-specific config
• 8 doc-tests pass
• System test binary extended with fail subcommand for simulating crashing services
• New Windows system test (should_stop_winsw_service_after_max_retries) — needs CI run to
  verify on Windows

🤖 Generated with Claude Code

[jacderida]

Hey @chipsenkbeil

I'm marking this PR as a work in progress until I ensure the new test passes.

I was able to add quite an elaborate system test with the help of Claude, but it may take a few iterations to get it to pass.

Right now I'm only providing this feature for Windows because that is the platform I'm concerned about, but we could extend to support other platforms.

[chipsenkbeil]

@jacderida sounds good. I'm just now trying out claude and opencode and am pretty blown away by the effectiveness and speed. So looking forward to what you produce here!

[jacderida]

@jacderida sounds good. I'm just now trying out claude and opencode and am pretty blown away by the effectiveness and speed. So looking forward to what you produce here!

Cool.

Honestly, if you spend a bit of time getting a good Claude Code setup, the productivity gains are unbelievable, and it's a lot of fun to work with. Set yourself up with a custom skill that interviews you to plan out every piece of work. With adequate planning and control, the results are extremely impressive and you can just churn through features. Have fun! :)

[jacderida]

Hey @chipsenkbeil

This appears to be working OK, so I took the "WIP" out of the title.

The automated test passes and I also tested it in the context of my own application.

If you could approve the PR, I will get it merged and released.

Thanks.

[jacderida]

Hey @chipsenkbeil

I hope you don't mind, but I'm going to merge this.

I need it for a release we are doing very soon.

[chipsenkbeil]

@jacderida yep, all good. :) I'm on vacation this week and not checking often. You've got access to merge and publish so that I'm not a blocker! I trust you :D

[jacderida]

@jacderida yep, all good. :) I'm on vacation this week and not checking often. You've got access to merge and publish so that I'm not a blocker! I trust you :D

Awesome, thanks! I got it merged and released.