[Android] distinguish read and notification for future completion

[hgrf]

Hi Chip,

sorry I did not reply to your comments on #1080.

I have rebased it, rewritten it to use an enumeration and also made "receiveEvent" optional in the constructor of BmCharacteristicData, so that it does not break the Linux and web implementations. I think both of them support this distinction, so if you want me to, I can implement and test it.

[chipweinberger]

thanks for the update.

1. now that i see it in use, receiveType is a better name
2. will this run on web & linux? i think you need more changes

[chipweinberger]

.where((p) => p.receiveEvent != BmReceiveEventEnum.notify);

don't like this so much.

ideally make it clear it is android only, or check for indicate or unknown

[chipweinberger]

lets make it required, for consistency

[tnc1997]

Leaving it optional means that we need not make this a breaking change and would be better if possible.

We could default to BmReceiveEventEnum.unknown or we could make the field nullable as done for pin.

#1119 (comment)

[chipweinberger]

breaking is fine tho. I still dont really understand why we wouldn't want to break.

now is the perfect time to break since we have no other users of this interface.

[tnc1997]

#1119 (comment)

[chipweinberger]

lets make this nullable

[chipweinberger]

lets make an explicit 'parse' helper function

[chipweinberger]

lets just have this:

enum BmReceiveType {
  read, // 1
  notify, // 2
}

and then make it nullable, and have a BmReceiveType? _parseReceiveTypeFromInteger function