[Android] platform code cleanup

[ekuleshov]

A relatively large change, but mostly about tidying Android platform code:

• inconsistent formatting
• unnecessary cast, generics, final, etc
• unused imports
• replaced new HashMap() with Map.of() - should be more efficient
• Activity and Context checks to help with [Help]: NullPointerException: Attempt to read from field 'java.lang.Object p1.o.a' #1215

It may use some additional testing. These changes touch some functionality I don't use...

[ekuleshov]

@chipweinberger this seem to be a bug. I assumed here should be a loop

[ekuleshov]

@chipweinberger seem to be another string comparison bug

[chipweinberger]

if you feel confident in it, feel free to merge and release it

[ekuleshov]

if you feel confident in it, feel free to merge and release it

I'll try to do some more testing before making a release.

@chipweinberger did you see my notes in the waitIfBonding() method? Does that change look right to you? I'm not sure how to test it.

[chipweinberger]

yes it looks right. a little surprising that we've gone so long with it "broken"

it's a "best practice" to not do anything else while bonding

[Gaby-Torres]

Just checking in on this PR, my team is experiencing bonding latency and are curious as to whether this has shown improvement in bonding performance?

[chipweinberger]

no it will have no effect

[chipweinberger]

we should probably just remove waitIfBonding all together

the code works as is. we shouldn't change functionality thats working.

[chipweinberger]

just closing to tidy things up

given the merge conflicts, you'd probably want to start fresh.

[ekuleshov]

just closing to tidy things up
given the merge conflicts, you'd probably want to start fresh.

@chipweinberger I could have still merged the conflicts...

BTW, the last release missing the change logs and it is also fail to build on Android.
Issue introduced in this change

.../.pub-cache/hosted/pub.dev/flutter_blue_plus_android-5.0.1/android/src/main/java/com/lib/flutter_blue_plus/FlutterBluePlusPlugin.java:970: error: incompatible types: bad type in conditional expression
                    String inst = (instanceId != null ? instanceId : "noinst");
                                                        ^
    Integer cannot be converted to String
.../.pub-cache/hosted/pub.dev/flutter_blue_plus_android-5.0.1/android/src/main/java/com/lib/flutter_blue_plus/FlutterBluePlusPlugin.java:1104: error: incompatible types: bad type in conditional expression
                    String inst = (instanceId != null ? instanceId : "noinst");
                                                        ^
    Integer cannot be converted to String
.../.pub-cache/hosted/pub.dev/flutter_blue_plus_android-5.0.1/android/src/main/java/com/lib/flutter_blue_plus/FlutterBluePlusPlugin.java:1219: error: incompatible types: bad type in conditional expression
                    String inst = (instanceId != null ? instanceId : "noinst");
                                                        ^
    Integer cannot be converted to String
3 errors

[chipweinberger]

ok. reopened. please continue work on it!