Skip to content

fix: Remove drag on stage 3 #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baseplate-admin merged 1 commit into from
Mar 25, 2026
Merged

fix: Remove drag on stage 3 #587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/frontend/src/routes/(needs_onboarding)/(navbar_and_footer)/upload/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

const { config: configData } = useConfigQuery();

let stage = $state(1);
let stage = $state<1 | 2 | 3>(1);
let isDragging = $state(false);
let isDraggingOverCard = $state(false);
let isDraggingOverZone = $state(false);
Expand Down Expand Up @@ -51,6 +51,7 @@
};

const handleWindowDragEnter = (e: DragEvent) => {
if (stage === 3) return;
e.preventDefault();
dragCounter++;
if (e.dataTransfer) {
Expand All @@ -60,6 +61,7 @@
};

const handleWindowDragLeave = (e: DragEvent) => {
if (stage === 3) return;
dragCounter--;
if (dragCounter <= 0) {
isDragging = false;
Expand All @@ -68,11 +70,13 @@
};

const handleWindowDragOver = (e: DragEvent) => {
if (stage === 3) return;
e.preventDefault();
if (!isDragging) isDragging = true;
};

const handleWindowDrop = (e: DragEvent) => {
if (stage === 3) return;
e.preventDefault();
dragCounter = 0;
isDragging = false;
Expand All @@ -84,11 +88,13 @@
};

const handleCardDragEnter = (e: DragEvent) => {
if (stage === 3) return;
e.preventDefault();
isDraggingOverCard = true;
};

const handleCardDragLeave = (e: DragEvent) => {
if (stage === 3) return;
const currentTarget = e.currentTarget as Node;
const relatedTarget = e.relatedTarget as Node;
if (currentTarget && relatedTarget && currentTarget.contains(relatedTarget)) {
Expand Down Expand Up @@ -316,6 +322,7 @@
isDraggingOverZone && 'shadow-[0_0_60px_-10px_var(--primary)]'
]}
ondrop={(e) => {
if (stage === 3) return;
e.preventDefault();
e.stopPropagation();
dragCounter = 0;
Expand Down