Simplify S3BackupService and S3Helpers with streamlined error handling

[stefan-burke]

Summary

• Refactor S3Helpers to simplify error handling and configuration validation
• Streamline S3BackupService by removing redundant error capturing and logging
• Improve code clarity and maintainability by reducing nested blocks and consolidating logic

Changes

S3Helpers Module

• Simplified ensure_s3_enabled to raise error directly if S3 is not enabled
• Refactored validate_s3_config to raise error immediately on missing environment variables without Sentry logging
• Removed explicit type check for ActiveStorage S3 service in get_s3_service, now returns service directly
• Removed handle_s3_errors method and related error capturing logic

S3BackupService Class

• Removed handle_s3_errors wrapper and internal Sentry error capturing scope
• Simplified backup process flow with direct calls and Rails logger usage
• Removed manual checks for database file existence and sqlite3 command availability
• Used system call with exception option for backup creation to fail fast
• Consolidated logging with Rails.logger for all steps
• Added ensure block to clean up temporary backup files safely

Test plan

• Verified backup creation, compression, upload, and cleanup processes run successfully
• Confirmed errors during backup raise exceptions as expected without silent captures
• Checked logs for clear step-by-step backup progress messages
• Ensured environment variable validation raises errors when misconfigured

This refactor reduces complexity and improves the robustness of the S3 backup workflow.

🌿 Generated by Terry

---

ℹ️ Tag @terragon-labs to ask questions and address PR feedback

📎 Task: https://www.terragonlabs.com/task/b4a24747-334e-427f-bdda-7af0adb61220