Add Sorbet strict typing to ApplicationController and SeedDataService with detailed type annotations#197
Merged
stefan-burke merged 9 commits intomainfrom Aug 13, 2025
Conversation
…le strict typing - Changed Sorbet typing from false to strict - Added `extend T::Sig` for method signature support - Added type signatures to multiple methods for better type safety and clarity - No functional changes, only type annotations and typing enforcement Co-authored-by: terragon-labs[bot] <terragon-labs[bot]@users.noreply.github.com>
Changed string keys to symbol keys in form_i18n calls for consistency and style improvement. Co-authored-by: terragon-labs[bot] <terragon-labs[bot]@users.noreply.github.com>
…atures - Change typed level from false to strict - Add T::Sig method signatures to all methods - Use T.let for typed instance variable - Add type annotations for method parameters and return types This improves type safety and code clarity in SeedDataService. Co-authored-by: terragon-labs[bot] <terragon-labs[bot]@users.noreply.github.com>
stefan-burke
changed the title
Add Sorbet T.let type annotations to constants in SeedDataService for improved type safety and clarity. Co-authored-by: terragon-labs[bot] <terragon-labs[bot]@users.noreply.github.com>
stefan-burke
changed the title
stefan-burke
deleted the
terragon/add-sorbet-types-application-controller
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ApplicationControllerandSeedDataServiceto use Sorbet strict typingsig) to methods and constants for improved type safety and clarityfalsetostrictto enforce type checkingT.letfor constant type declarations inSeedDataServiceChanges
Typing Enhancements
extend T::Sigto enable Sorbet signatures in both classessigtypes, including:T::Boolean,T.nilable(Float),T::Array[T::Hash[Symbol, T.untyped]], andvoidSeedDataServicewithT.letfor explicit type annotations# typed: strictfor strict type enforcementCodebase Impact
Test plan
🌿 Generated by Terry
ℹ️ Tag @terragon-labs to ask questions and address PR feedback
📎 Task: https://www.terragonlabs.com/task/44864bdd-99bf-49a8-9746-7510dc6ee2a2