Remove JsonSerializerService and update related tests

[stefan-burke]

Summary

• Completely removes the JsonSerializerService class and its associated spec file
• Updates tests to no longer call JsonSerializerService directly
• Modifies request specs to test JSON responses through API endpoints instead of direct serialization

Changes

Code Removal

• Deleted app/services/json_serializer_service.rb which provided JSON serialization for units, inspections, and assessments
• Deleted spec/services/json_serializer_service_spec.rb which contained extensive tests for the removed service

Test Updates

• In spec/requests/api/units_json_inspection_history_spec.rb, replaced direct calls to JsonSerializerService.serialize_unit with actual API requests to /units/:id.json and parsing the response
• In spec/requests/api/units_json_real_world_spec.rb, removed direct serialization calls and rely solely on API endpoint responses
• In spec/requests/inspections/inspections_spec.rb, removed stubbing of JsonSerializerService.serialize_inspection and added assertions on actual JSON response keys to verify presence of expected data

Test plan

• Verified all modified request specs pass successfully
• Confirmed that JSON responses from API endpoints contain expected keys and data without relying on the removed service
• Ensured no references to JsonSerializerService remain in the codebase or tests

🌿 Generated by Terry

---

ℹ️ Tag @terragon-labs to ask questions and address PR feedback

📎 Task: https://www.terragonlabs.com/task/27a0505b-fd58-4928-b4ed-66f7849da27e