Remove unused methods from assessment models#234
Merged
stefan-burke merged 1 commit intomainfrom Aug 22, 2025
Merged
Conversation
…sult - Removed unused ropes_compliant? method from MaterialsAssessment - Removed runout_compliance_status method from SlideAssessment - Moved anchorage_result method to private section in AnchorageAssessment - Cleaned up code by removing commented or redundant lines These changes improve code clarity and maintainability by removing dead code and organizing methods logically. Co-authored-by: terragon-labs[bot] <terragon-labs[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
anchorage_resultmethod inAnchorageAssessmentto private scoperopes_compliant?method fromMaterialsAssessmentrunout_compliance_statusmethod fromSlideAssessmentChanges
AnchorageAssessment
anchorage_resultmethod to private section to encapsulate itMaterialsAssessment
ropes_compliant?method as it is not used anywhereSlideAssessment
runout_compliance_statusmethod which was unusedTest plan
🌿 Generated by Terry
ℹ️ Tag @terragon-labs to ask questions and address PR feedback
📎 Task: https://www.terragonlabs.com/task/40f75958-454a-4296-bc48-7d90e818d3be