(#1120) Fix gathering of files for signing#1121
Merged
gep13 merged 1 commit intochocolatey:hotfix/3.0.1from Mar 25, 2026
Merged
(#1120) Fix gathering of files for signing#1121gep13 merged 1 commit intochocolatey:hotfix/3.0.1from
gep13 merged 1 commit intochocolatey:hotfix/3.0.1from
Conversation
Member
Author
|
@AdmiringWorm also converting this one to draft for now, until we have a path forward on when this will be going out, along with the other changes that we have in the pipeline for GUI. |
gep13
force-pushed
the
issue-1120
branch
2 times, most recently
from
2e83c40 to
3a24864
Compare
Member
Author
|
@AdmiringWorm can I get a final review from you on this one? Thanks! |
With the introduction of dotnet build, rather than msbuild, the new net48 folder is causing an issue with gathering of files that need to be signed using the Chocolatey authenticode certificate. There are a number of files added to the net48 folder that _need_ to be signed, but these are not being picked up since the globbing pattern doesn't look in this folder. This commit updates the globbing pattern to include this folder, and also adds an assertion about the number of files that are expected to be found from each glob. This should prevent this from happening again, since the updating of the asserted version number should _only_ be done, when the number of expected files has been known to change.
Member
Author
|
@AdmiringWorm actually, looks like your approval is still valid. So going to move forward with getting this merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description Of Changes
There are a number of files added to the net48 folder that need to be signed, but these are not being picked up since the globbing pattern doesn't look in this folder.
This commit updates the globbing pattern to include this folder, and also adds an assertion about the number of files that are expected to be found from each glob. This should prevent this from happening again, since the updating of the asserted version number should only be done, when the number of expected files has been known to change.
Motivation and Context
With the introduction of dotnet build, rather than msbuild, the new net48 folder is causing an issue with gathering of files that need to be signed using the Chocolatey authenticode certificate.
Testing
@corbob has updated the Test-Kitchen tests to correctly identify all files that need to be checked.
Once this PR is merged, we should run the Test-Kitchen test, which is currently failing and ensure that it passes correctly
Operating Systems Testing
Dev VM 4
Change Types Made
Change Checklist
Related Issue
Fixes #1120